[ previous ] [ next ] [ threads ]
 
 From:  "Jonathan De Graeve" <Jonathan dot De dot Graeve at imelda dot be>
 To:  <m0n0wall dash dev at lists dot m0n0 dot ch>
 Subject:  Redundant functions - CODE CLEANUP REQUEST
 Date:  Fri, 25 Nov 2005 22:43:51 +0100
For example, redundant functions in captiveportal.inc and
captiveportal/index.php:

DOUBLE: function captiveportal_get_radius_servers
DOUBLE: function captiveportal_lock
DOUBLE: function captiveportal_unlock
ALMOST DOUBLE: function captiveportal_logportalauth 

And I'm pretty sure there other pieces of code that are redundant. 
IMHO The whole code is a mess... :(

What I want todo is cleanup this functions and create a dedicated file
radius_functions.inc in /etc/inc/

Also cleaning up the require functions (ok, they are 'require_once'
functions but its lazy you leave them like that (double calls) and can
lead to confusions and other errors)

It would be nice if everybody could have a look at there
require/includes or even functions and see if its really necessary or if
they can be put in a proper locations, giving me the list and I will do
the cleanup...

Kind Regards,

J.

--
Jonathan De Graeve
Network/System Administrator
Imelda vzw
Informatica Dienst
015/50.52.98
Jonathan dot de dot graeve at imelda dot be