Re: [m0n0wall-dev] Captive Portal MAC Pass-Through + Radius Reauthentication

From:	Manuel Kasper <mk at neon1 dot net>
To:	Peter Allgeyer <allgeyer at web dot de>
Cc:	m0n0wall dash dev at lists dot m0n0 dot ch
Subject:	Re: [m0n0wall-dev] Captive Portal MAC Pass-Through + Radius Reauthentication
Date:	Sat, 3 May 2008 20:45:38 +0200

Hi Peter,

On 24.04.2008, at 10:39, Peter Allgeyer wrote:

> I've written and tested a patch against that. See attachment. Can you
> please take a look at it and tell me, if it'll be included in 1.3b12?

Sorry for the late reply, and thanks for your patch! It looks good,  
and I've just committed it to the repository for inclusion in 1.3b12.  
Perhaps the "MAC DB" should be read in only once and stored in an  
array, so that the file doesn't have to be opened and searched through  
for each client that is online when captiveportal_prune_old() runs.  
But then again, the whole captive portal stuff should probably be  
rewritten to use something a bit more efficient (like SQLite or BDB)  
some day anyway...

Regards,

Manuel