[ previous ] [ next ] [ threads ]
 
 From:  Peter Allgeyer <allgeyer at web dot de>
 To:  m0n0wall dash dev at lists dot m0n0 dot ch
 Subject:  Re: [m0n0wall-dev] Captive Portal MAC Pass-Through + Radius Reauthentication
 Date:  Thu, 24 Apr 2008 10:39:03 +0200
Am Dienstag, den 22.04.2008, 22:53 +0200 schrieb Peter Allgeyer:
> I think I've found the cause of the problem in the source:
> 
> /etc/inc/captiveportal.inc: function captiveportal_prune_old()
> 
>     /* read database */
>     $cpdb = captiveportal_read_db();
> 
>     [..]
> 
>     $no_users = count($cpdb);
>     for ($i = 0; $i < $no_users; $i++) {
> 
> It reads in a list of all recognized hosts and iterates on the numbver
> of hosts found. Then, it checks for "hard timeout",
> "Session-Terminate-Time", "radius idle_timeout", "radius
> session_timeout" and so on. Last there's a check for "RADIUS
> reauthentication". I think, in case of Pass-Through mac addresses, we
> don't have to check for any of those timeouts, just letting that hosts
> stay connected. So excluding the hosts listed
> in /var/db/captiveportal_mac.db (or better(?) <passthrumac>) from any
> test in captiveportal_prune_old would be nice and doesn't lead to
> misinterpretations.

I've written and tested a patch against that. See attachment. Can you
please take a look at it and tell me, if it'll be included in 1.3b12?

Regards,
 PIT


---------------------------------------------------------------------------
 copyleft(c) by |   _-_     Beeping is cute, if you are in the office ;)
 Peter Allgeyer | 0(o_o)0   -- Alan Cox
---------------oOO--(_)--OOo-----------------------------------------------
captiveportal_fixed_mac_1.3b11.patch (2.1 KB, text/x-patch)