[ previous ] [ next ] [ threads ]
 
 From:  Manuel Kasper <mk at neon1 dot net>
 To:  Stephane Billiart <stephane dot billiart at gmail dot com>
 Cc:  m0n0wall dash dev at lists dot m0n0 dot ch
 Subject:  Re: [m0n0wall-dev] cleanup/logout patch and RFC
 Date:  Sun, 13 Sep 2009 10:03:43 +0200
Hello Stephane,

thanks for your patches! You're right that the logout/session status  
in m0n0wall's captive portal could be better... And yes, allowing the  
session status/logout HTML to be defined by the user, with  
placeholders for username/IP/session end/etc. as desired, would be the  
preferred solution. But anyway - I've taken a look at your patches,  
and they look OK to me; I'll commit them (or your latest version by  
that time :) to the repository after m0n0wall 1.3 has been released.

Regards,

Manuel

On 08.09.2009, at 19:56, Stephane Billiart wrote:

> Hi, I am new to the list.
> I used m0n0wall a few years ago and started playing with it again  
> recently.
>
> I really like the overall features and ease of administration of  
> m0n0wall
> but I have a few issues:
> - no logout page (I do not like the popup)
> - no way for local users to change their password
> - user authentication is local (x)or radius, I would like to be able
>  to check local users first then radius
> - captive portal on only one interface
>
> I started working on the first item and attached are two patches for
> /usr/local/captiveportal/index.php, they should apply cleanly against
> 1.3b18
>
> The first patch is just some minor cleanups (removing trailing white
> spaces) and code simplification of http/https handling.
>
> The second patch adds a 'status' page when a connected user connects
> his browser to the portal and allows him to logout as well.
> When a user logs in, a cookie with the sessionid is sent to the  
> browser
> which allows the script to find users securely. I had to make minor
> modification to the popup code so that it can coexist with the new
> logout form.
>
> I am now working on making the status page configurable so that admin
> can modify it easily (add/remove some session information, add a  
> password
> change form...) but I have not figured out all the details yet.
>
> I would be grateful if people could review and comment on these  
> patches
> and consider them for inclusion after corrections.
>
> Thank you,
>
> -- 

> billiart/
> < 
> index.php.cleanup.patch 
> > 
> < 
> index.php.logout.patch 
> >---------------------------------------------------------------------
> To unsubscribe, e-mail: m0n0wall dash dev dash unsubscribe at lists dot m0n0 dot ch
> For additional commands, e-mail: m0n0wall dash dev dash help at lists dot m0n0 dot ch