[ previous ] [ next ] [ threads ]
 
 From:  Vincent Fleuranceau <vincent at bikost dot com>
 To:  m0n0wall dash dev at lists dot m0n0 dot ch
 Subject:  [Fwd: Re: Racoon(8) Deleting SPD Entries]
 Date:  Tue, 03 Aug 2004 17:01:24 +0200
For your information:

-- Vincent


-------- Original Message --------
Subject: Re: Racoon(8) Deleting SPD Entries
Date: Tue, 3 Aug 2004 16:36:14 +0200 (CEST)
From: Helge Oldach <kame530 at oldach dot net>
To: vincent at bikost dot com (Vincent Fleuranceau)

Hi Vincent,

> I'm experiencing the problem you describe in your post.
> 
> Reference:
> 
>   http://www.mail-archive.com/freebsd dash net at freebsd dot org/msg10867.html
>   http://orange.kame.net/dev/query-pr.cgi?pr=530
> 
> I just would like to know if the bug has been fixed now?

It apparently hasn't been fixed by KAME, as the PR is still open.
However I have reworked the patch slightly. This will avoid a spurious
error message. See below.

Regards,
Helge


--- isakmp_quick.c.orig	Tue Oct 21 09:18:03 2003
+++ isakmp_quick.c	Mon Apr 12 19:55:27 2004
@@ -2012,7 +2012,7 @@

  	/* get inbound policy */
  	sp_in = getsp_r(&spidx);
-	if (sp_in == NULL) {
+	/* if (sp_in == NULL) */ {
  		if (iph2->ph1->rmconf->gen_policy) {
  			plog(LLV_INFO, LOCATION, NULL,
  				"no policy found, "
@@ -2027,9 +2027,11 @@
  			memcpy(iph2->spidx_gen, &spidx, sizeof(spidx));
  			return -2;	/* special value */
  		}
+		else if (sp_in == NULL) {
  		plog(LLV_ERROR, LOCATION, NULL,
  			"no policy found: %s\n", spidx2str(&spidx));
  		return ISAKMP_INTERNAL_ERROR;
+		}
  	}

  	/* get outbound policy */