[ previous ] [ next ] [ threads ]
 
 From:  Amaury Amblard-Ladurantie <darcache at gmail dot com>
 To:  Paul Taylor <PaulTaylor at winn dash dixie dot com>
 Cc:  Jonathan De Graeve <Jonathan dot De dot Graeve at imelda dot be>, m0n0wall at lists dot m0n0 dot ch
 Subject:  Re: [m0n0wall] Captive Portal: One Login per MAC
 Date:  Mon, 7 Nov 2005 14:26:08 +0100
Hello

Thank you for this information.
Would the element manager also detect this ?
<!--
  <img src="img.png" />
-->

The HTML code loading the image is nested inside HTML comments.
Therefore the image is not displayed on the page.

It could allow someone to manually load any image required by the css.
Best regards,
Amaury

On 11/7/05, Paul Taylor <PaulTaylor at winn dash dixie dot com> wrote:
>
> All,
>
> In addition to image tags, it does also detect other types... This line is
> taken from our captive portal login page, which loads our css file:
>
> <link href="css/cp.css" rel="stylesheet" type="text/css">
>
> I haven't tried Javascript, but I believe it will work also.
>
> Now, if your css file links out to other images, that won't work...  The
> element manager only scans the login and error html pages for links.
>
> Also, the path does not matter...  Note that the above shows "css/cp.css" as
> the location of the css file...  I'm stripping the paths out when I grab the
> elements.
>
> Paul
>
> -----Original Message-----
> From: Jonathan De Graeve [mailto:Jonathan dot De dot Graeve at imelda dot be]
> Sent: Monday, November 07, 2005 6:40 AM
> To: Amaury Amblard-Ladurantie
> Cc: Paul Taylor
> Subject: RE: [m0n0wall] Captive Portal: One Login per MAC
>
>
> >Does it detect that it needs to load external stylesheets and/or
> >Javascript files?
> >Does it detect that a stylesheet needs external PNG?
> No
>
> As my guess is "no it does not"; I imagined a "hack" to force the
> element manager to detect the fact that it needs external files.
> I have included in the HTML file a comment such as this one:
> <!--
> <img src="img1.png" />
> <img src="img12.png" />
> <img src="stylesheet.css" />
> <img src="javascript.js" />
> -->
> Didn't test this but it could work.
>
> >Even if this works, this is nothing more than an ugly hack. Would you
> >mind implementing something in element manager which would detect and
> >load the following elements ?
> <!--
>
>   This elements are needed by the webpage
>   element="stylesheet.css"
>   element="javascript.js"
>   element="img1.png"
>
> -->
> This is for Paul, I'm not going to add more features to the element
> manager, only bug fixes (like the one in the
> system_write_captive_portal_elements).
> I'm too busy with other enhancements ;)
>
> >Final question: which path do I use to load the external files?
> >In my test web page I use the local relative path:
> ><img src="image.png" />
> >
> >Is it going to work?
>
> Yes
>
> J.
>
>