[ previous ] [ next ] [ threads ]
 
 From:  YvesDM <ydmlog at gmail dot com>
 To:  m0n0wall at lists dot m0n0 dot ch
 Subject:  Re: [m0n0wall] problem with captiveportal (locking problem?) - sessions gone m
 Date:  Wed, 12 Dec 2007 12:29:22 +0100
jan dash ake dot ronnblom at skeria dot skelleftea dot se> wrote:

> YvesDM <ydmlog at gmail dot com> writes:
> >
> >Interesting,
> >
> >I got a look-a-like issue too from time to time.
> >Users are shown logged in on the CP status page with 0 bytes up/down.
> >These sessions can reside for days, untill I clean them manually from
> >m0n0wall webif.
> >When it happens, that particular user is unable to login untill the
> session
> >is manually cleaned.
> >I 'll build a custom image with your patch and see what it brings me, tnx
> >;-)
>
> You're welcome. However my patch causes users to be IMMEDIATELY
> logged out if they haven't sent any trafic before the cleanup script
> "captiveportal_prune_old()" is run. So perhaps there is a race which
> possibly could loggoff a user without them getting a chance to send any
> data.
>
> Perhaps the "real" fix should either set the $lastact to time() if its 0:
>
> $lastact = $lastact ? $lastact : time();
>
> This would loggoff the user when the timeout has expired and the user
> hasn't
> sent any data.
>

Yes indeed, I get it.
I will try it out as soon as my holidays are over ;-)

Kind regards,
Y.